Wrap image paths in angle brackets#2
Open
josephyooo wants to merge 1 commit intoMarkEdit-app:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spaces in image path not accounted for. CommonMark says to use angle brackets.
Thus, I wrapped the image path in angle brackets. Pasting images with spaces in the path now works.
Risks
Angle brackets are allowed in paths on macOS/Linux, but aren't allowed unescaped, per CommonMark. Perhaps it could be implemented with:
const escaped = newFileName.replace(/[\\<>]/g, '\\$&');